Some updates to the API for archived repos #27149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
the
modifies/api
delvh
reviewed
Sep 20, 2023
routers/api/v1/repo/branch.go
Outdated
| @@ -117,17 +117,13 @@ func DeleteBranch(ctx *context.APIContext) { | |||
| // "$ref": "#/responses/error" | |||
| // "404": | |||
| // "$ref": "#/responses/notFound" | |||
|
|
|||
| // "423": | |||
| // "$ref": "#/responses/repoArchived" | |||
There was a problem hiding this comment.
Please also add a description, here and everywhere else:
Suggested change
| // "$ref": "#/responses/repoArchived" | |
| // "$ref": "#/responses/repoArchived" | |
| // "description": "The repo is archived" |
There was a problem hiding this comment.
The description is added by swagger automatically
delvh
approved these changes
Sep 20, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Sep 21, 2023
GiteaBot
added
lgtm/done
jolheiser
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 22, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin Updates to the API for archived repos (go-gitea#27149) Fix release URL in webhooks (go-gitea#27182) Fix dropdown icon position (go-gitea#27175) Fix repo sub menu (go-gitea#27169) Fix review request number and add more tests (go-gitea#27104) Fix the variable regexp pattern on web page (go-gitea#27161) Fix organization field being null in POST /orgs/{orgid}/teams (go-gitea#27150) Add index to `issue_user.issue_id` (go-gitea#27154) [skip ci] Updated translations via Crowdin Start development on Gitea 1.22 (go-gitea#27155) Fix successful return value for `SyncAndGetUserSpecificDiff` (go-gitea#27152)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with the API for archived repos I found some nits that this PR fixes.
ApplyDiffPatchfor an archived repo, it now returns aErrRepoIsArchivederror. Those functions should never be called if a repo is archived, so you should never get this error in theory, but it's better to make sure it doesn't happen.This PR makes no claim to completeness. I may have missed some function.